Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] DualShock added twice if DS4Windows/DS4Tools is installed and XInput support enabled #188

Closed
Rene-Damm opened this issue Jul 28, 2018 · 1 comment
Labels
bug Issues where existsing functionality misbehaves
Milestone

Comments

@Rene-Damm
Copy link
Contributor

If DS4Windows or DS4Tools is installed and XInput support is enabled, then a DualShock gamepad plugged into the machine will be visible both as a HID and as an XInput controller. This leads to the input system adding both a DualShockGamepadHID and an XInputControllerWindows gamepad for what underneath is the same device.

This is likely going to be hard to detect on our side. We filter out XInput HIDs added by Microsoft's driver to solve the same situation there. However, doing the same the DS4Windows/DS4Tools case is likely not going to be as straightforward.

The XInput API makes it impossible to tell which device sits behind an XInput controller index. So to handle this case, it seems we'll have to determine whether a given HID is a DualShock controller and then detect whether DS4Windows/DS4Tools is present and running with XInput enabled for the app.

Hopefully there's a simpler solution.

@Rene-Damm Rene-Damm added the bug Issues where existsing functionality misbehaves label Jul 28, 2018
@Rene-Damm Rene-Damm added this to the 2018.2 milestone Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues where existsing functionality misbehaves
Projects
None yet
Development

No branches or pull requests

2 participants