Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: replace MLAPI namespace with Unity.Multiplayer.Netcode #1007

Merged
merged 4 commits into from Aug 3, 2021

Conversation

ThusSpokeNomad
Copy link
Contributor

part of our upcoming MLAPI rebranding, we need to change our namespaces around the codebase.

@SamuelBellomo
Copy link
Contributor

I'm wondering if using "Unity.NGO" instead of "Unity.Netcode" would be better to differentiate with dots netcode.

.editorconfig Outdated Show resolved Hide resolved
@becksebenius-unity
Copy link
Contributor

Changes LGTM assuming there's alignment on the namespace. I don't have a problem with it, although tools is using Unity.Multiplayer and we may want to change that too to follow suit (I'll follow up on this).

@becksebenius-unity
Copy link
Contributor

This will need some really good messaging so internal devs all know what to expect, and any outstanding PRs know to merge backwards even if there's no conflicts.

@mattwalsh-unity
Copy link
Contributor

Yeah, @becksebenius-unity I think you're right, I think we'd have to all move under Unity.Netcode

@SamuelBellomo
Copy link
Contributor

Yeah, @becksebenius-unity I think you're right, I think we'd have to all move under Unity.Netcode

For Boss Room, I'd lean toward keeping with our "BossRoom" namespace, since it's all user side code. It'd make sense to not mix namespaces for this.

@ThusSpokeNomad ThusSpokeNomad changed the title chore!: replace MLAPI namespace with Unity.Netcode chore!: replace MLAPI namespace with Unity.Multiplayer.Netcode Aug 3, 2021
@ThusSpokeNomad ThusSpokeNomad enabled auto-merge (squash) August 3, 2021 00:26
@ThusSpokeNomad ThusSpokeNomad merged commit c8eb5fc into develop Aug 3, 2021
@ThusSpokeNomad ThusSpokeNomad deleted the chore/namespaces branch August 3, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants