-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big Input Interruptions Analyzed #164
Comments
Do you mean that the input lag caused by the changes of signaling feature? No major changes between 2.0.0-preview and 2.0.1-preview, so it should be reproduced with the 2.0.0-preview. |
Hey! Thanks for getting back. Yes we believe it must be somehow signaling - we can reproduce this by coming from 200 (everything fine) to 201 (shows effect after 1 minute) |
EDIT: I did not have this same bug. I have registered a new bug instead, as #180 We are seeing the same behaviour. I had not reported it yet because I though the error was in our own code, and I wanted to do some more tests. But to be clear: @WaltzBinaire: Am I correct in assuming that you mean that the bug is in the receiving and/or parsing of the inputChannel data? Note that the word "signaling" in WebRTC-context is mostly used about the setup of the WebRTC communication (through a "signaling server"), and not for the sending of control signals over the WebRTC data channel(s) when the WebRTC connection has been set up. |
hey @eirikwah - absolutly - thanks for clarifying my sloppy expression which can lead to confusion. It has nothing to do with signaling server - it is related to incoming inputchannel data - that has a lacky behavior introduced between 200 and 201 |
Hi @karasusan !
|
Thanks for your cooperation. I guess the issue caused by Input System. I am currently investigating the issue. |
I am checking the issue with the latest version of package (2.1.0-preview.1) but not reproduced. |
Hi Karasusan, you mean the dev branch on github? the latest in package manager is 2.0.5 preview for webrtc and 2.0.2 preview for unity render streaming. My setup is 2019.3 and 2.0.2 of render streaming. I'd love to test 2.1 if an official release is made. |
Thanks @thomasvanta, Please try it if you can. |
I was checking the HDRP sample and couldn't replicate there either. |
The latest version of the template project is here |
@thomasvanta |
My previous message stating that I also experienced this bug was wrong. Sorry for my confusion. I have registered a new bug instead, as #180 |
@karasusan we see that the quality of the video got much better and it seems as if it was connected to the interruptions. Which is really great as it pushed the quality by a huge margin. However we also stumble across the issues mentioned by @thomasvanta -
|
Sure, although we are investigating this issue already, |
@karasusan very cool - i will open a new bug with description from our side - furthermore i would consider the input lag to be resolved as we were not able to create this again with the new 2.1.0 preview.4 - SO SOLVED - THANK YOU |
I reopened the issue because of the comment. |
@karasusan where you able to recreate the issue? |
@WaltzBinaire |
@karasusan thank you! |
cant reproduce this issue anymore with latest adjustments here #191 - Thank you @karasusan |
We have found a bigger unnecessary bug that is driving us crazy since weeks. About the way the input communication from the Webserver to Unity works.
You can test this bug on WebRTC 2.0.0 vs WebRTC 2.0.1 - 2.0.5. There must be a signaling change that was introduced in 2.0.1 - which destroys the communication.
To Reproduce
Start Demo - add a rotating cube - play - rotate your camera for a while. You create continuous signals lets say via dragging - while looking at the rotating cube.
After a minute you will see an input lag/ stuttering - while you will see the cube continuing to rotate. This means that the image transfer is perfectly fine - but the signals are
I believe there must be somewhere a one liner of code - that was introduced in 2.0.1 - that causes this problem - that many people on the forum refer to as "image lack" while it actually is an input bug - totally ruins the experience - and could be fixed real quick. Please help out here
Environment (please complete the following information):
Windows
chomre
Unity Version 2019.3.9
Package version 2.0.1-preview
The text was updated successfully, but these errors were encountered: