Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make com.unity.webrtc work with Wwise #920

Closed
Nemo-G opened this issue Jun 9, 2023 · 4 comments
Closed

Make com.unity.webrtc work with Wwise #920

Nemo-G opened this issue Jun 9, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request issued This means the ticket is already created on internal issue tracker waiting for release This issue is already fixed and will be contained in next version
Milestone

Comments

@Nemo-G
Copy link

Nemo-G commented Jun 9, 2023

Is your feature request related to a problem?

I'm recently looking into a case when clients disable Unity default audio(FMOD) and use Wwise as the only Sound Engine in Unity. So we'd make unity webrtc support Wwise.

Describe the solution you'd like

I would like two methods added.

  1. A GetData method so that I can pull audio from webrtc track into Wwise source plugin
  2. A UnsafeSetData method so that I can feed data from Wwise effect plugin into webrtc audio track

See this PR #919

Describe alternatives you've considered

I think the two function is pretty straight-forward.

Additional context

No response

@karasusan
Copy link
Collaborator

Thanks for making the pull request. I posted the message on the PR. Can you confirm?

@Nemo-G
Copy link
Author

Nemo-G commented Jun 13, 2023

Hi @karasusan Replied in PR #919

Maybe it is other Unity check failed like NativeContainer instead of Allocator type. I haven't tested against all available types.

Since the buffer to copy is not managed by Unity, a straight forward marshal copy here can prevent all unnecessary operations like checking, introduce no side effect and deliver right away with no time wasted.

@karasusan
Copy link
Collaborator

@Nemo-G
Thank you for sharing more detail. I'm going to check SetData API implementation and fix this issue.

@karasusan karasusan added the issued This means the ticket is already created on internal issue tracker label Jun 20, 2023
@karasusan
Copy link
Collaborator

memo: WRS-481

@kannan-xiao4 kannan-xiao4 added the waiting for release This issue is already fixed and will be contained in next version label Jun 29, 2023
@kannan-xiao4 kannan-xiao4 added this to the 3.0.0-pre.6 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request issued This means the ticket is already created on internal issue tracker waiting for release This issue is already fixed and will be contained in next version
Projects
None yet
Development

No branches or pull requests

3 participants