Enhancements of docker environment setup

[kwea123]

I ran into some problems when launching docker, here are some of my suggestions:

1. When launching the environment, the correct command should be the following:

docker run \
  --env OTC_EVALUATION_ENABLED=true \
  --env OTC_DEMO_EVALUATION=true \
  --network=host \
  -it obstacle_tower_challenge:latest ./env.sh 5005 ObstacleTower/obstacletower.x86_64

The last two arguments must be provided, since the default path for the environment is set to
/home/otc/ObstacleTower/obstacletower.x86_64 which does not exist.

2. Please add --rm tag when launching docker containers:
   Do docker run --rm (other parameters...) all the time, otherwise lots of exited docker containers are going to be left behind, which consume disk space.

By the way, somehow the docker that runs ./run.sh doesn't terminate after the evaluation is done, we need to manually kill it by doing ctrl+c. Here's the output after ctrl+c:

^CTraceback (most recent call last):
  File "run.py", line 35, in <module>
    env.close()
  File "/srv/conda/lib/python3.6/site-packages/obstacle_tower_env.py", line 231, in close
    time.sleep(10)
KeyboardInterrupt

It looks like that it is stucked at closing the environment. I'm guessing it is trying to close an environment that is already closed (by the docker running env.sh)?

[awjuliani]

Hi @kwea123 We've just updated env.sh as follows: 33becd9. This should alleviate some of your issues. We will look into the second problem of ensuring the process ends correctly.