Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor tool to replace GameObjects with Prefabs #168

Merged
merged 2 commits into from Nov 15, 2020

Conversation

vishwah13
Copy link
Contributor

Created Editor tool to replace GameObject with Prefab
@CLAassistant
Copy link

CLAassistant commented Nov 11, 2020

CLA assistant check
All committers have signed the CLA.

@vishwah13
Copy link
Contributor Author

newly created Editor Tool to replace GameObject with Prefab

@Ogungodspower5
Copy link

Contact

@Ogungodspower5
Copy link

Ogungodspower5 commented Nov 11, 2020 via email

@vishwah13
Copy link
Contributor Author

Contact

how do i contact you

@vishwah13
Copy link
Contributor Author

vishwah13 commented Nov 11, 2020

if you don't want the Replaced object(Which is the prefab) to have the same Scale as Previous Object(the GameObject) then just remove this line inst.transform.localScale = go.transform.localScale; form ReplaceSelectedObject function on line 159

@amel-unity amel-unity added the tool A PR that contains an Editor tool or custom Inspectors label Nov 11, 2020
@ciro-unity ciro-unity changed the title Created Editor Tool Editor tool to replace GameObjects with Prefabs Nov 11, 2020
@ciro-unity
Copy link
Contributor

Hey @vishwah13, thanks. I'll review the PR shortly.
In the meantime, don't forget to give also PRs descriptive names or we need to get inside to know what they are about! I changed now.

@ciro-unity
Copy link
Contributor

I made a couple of tweaks to the script, and eliminated 90% of the comment which were very superfluous.
Also merged both classes in one script, no need for another file since the ScriptableObject is only part of this tool.
Also, I added a shoutout to the creator of the tutorial you took the code from.

@ciro-unity ciro-unity merged commit 785847d into UnityTechnologies:main Nov 15, 2020
@vishwah13
Copy link
Contributor Author

I made a couple of tweaks to the script, and eliminated 90% of the comment which were very superfluous.
Also merged both classes in one script, no need for another file since the ScriptableObject is only part of this tool.
Also, I added a shoutout to the creator of the tutorial you took the code from.

That's great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool A PR that contains an Editor tool or custom Inspectors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants