Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minoredits=exclude has no effect #226

Open
CorentinBrule opened this issue Apr 3, 2023 · 0 comments
Open

minoredits=exclude has no effect #226

CorentinBrule opened this issue Apr 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@CorentinBrule
Copy link

CorentinBrule commented Apr 3, 2023 •
edited
Loading

DynamicPageList3 version: 3.5.1
MediaWiki version: 1.39.1
PHP version: 8.2.0

List of steps to reproduce (step by step, including full links if applicable):

  • create a page with dpl tag like this:
<DPL>
namespace=
ordermethod=lastedit
minoredits=exclude
</DPL>
  • create a page in main namespace titled Page1
  • create another page in main namespace titled Page2
  • edit Page1 and save it
  • edit Page2 with "minor edit" option checked

What happens?:

the DPL output is:

  • Page1
  • Page2

What should have happened instead?:

the DPL output must be:

  • Page2
  • Page1
@CorentinBrule CorentinBrule added the bug Something isn't working label Apr 3, 2023
HamishSlater added a commit to hallowelt/DynamicPageList3 that referenced this issue Jun 16, 2023
@HamishSlater
Fix minoredits=exclude
2c72d81 
fixes issue Universal-Omega#226

Previously, the query selected the latest revision for each page based on the rev_timestamp, but did not consider the rev_minor_edit value until afterwards.
Now it will retrieve the latest revision that satisfies the condition rev.rev_minor_edit = 0.
@HamishSlater HamishSlater mentioned this issue Jun 16, 2023
Merged
Universal-Omega pushed a commit that referenced this issue Nov 6, 2023
@HamishSlater
Fix minoredits=exclude (#234)
61a6d31 
fixes issue #226

Previously, the query selected the latest revision for each page based on the rev_timestamp, but did not consider the rev_minor_edit value until afterwards.
Now it will retrieve the latest revision that satisfies the condition rev.rev_minor_edit = 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CorentinBrule