Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve query performance and add caching support #107

Merged
merged 43 commits into from
Mar 13, 2022

Conversation

Universal-Omega
Copy link
Owner

@Universal-Omega Universal-Omega commented Mar 9, 2022

  • Add ability to set maximum query time
  • Add support for query cache
  • Add pool counter support to limit query concurrency — usage of this would require additional setup

Additional changes:

  • Fix all MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures PHPCS violations, and enable it
    • Because some of the conversion of while to foreach is required for the caching support change
  • Unmark composer-test as experimental in CI
  • Rename Query::$DB property to Query::$dbr
  • Remove unused Parse::$DB property
  • Update README.md
    • Add documentation for new configuration
    • Minor markdown and wording changes
  • Some additional minor cleanup

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #107 (c89816c) into master (cd764c2) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #107   +/-   ##
========================================
  Coverage      0.00%   0.00%           
- Complexity     1559    1563    +4     
========================================
  Files            23      23           
  Lines          4323    4355   +32     
========================================
- Misses         4323    4355   +32     
Impacted Files Coverage Δ
includes/Article.php 0.00% <0.00%> (ø)
includes/DynamicPageListHooks.php 0.00% <ø> (ø)
includes/LST.php 0.00% <0.00%> (ø)
includes/Logger.php 0.00% <0.00%> (ø)
includes/Parse.php 0.00% <0.00%> (ø)
includes/Query.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd764c2...c89816c. Read the comment docs.

@Universal-Omega Universal-Omega merged commit 90c3c0e into master Mar 13, 2022
@Universal-Omega Universal-Omega deleted the Universal-Omega-patch-2 branch March 13, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants