Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumType incorrectly assigned for German decimals #483

Closed
rhdunn opened this issue Dec 3, 2023 · 8 comments
Closed

NumType incorrectly assigned for German decimals #483

rhdunn opened this issue Dec 3, 2023 · 8 comments

Comments

@rhdunn
Copy link
Contributor

rhdunn commented Dec 3, 2023

These numbers should be NumType=Frac instead of NumType=Card:

ERROR: Sentence answers-20111108024148AAO8oFI_ans-0010 token 3 -- CD/NumForm=Digit/NumType=Card lemma '3.40' does not match cardinal-number applied to form '3,40', expected '340'
ERROR: Sentence answers-20111108024148AAO8oFI_ans-0010 token 9 -- CD/NumForm=Digit/NumType=Card lemma '7.5' does not match cardinal-number applied to form '7,5', expected '75'

The following should also have the lemma 3.:

ERROR: Sentence email-enronsent00_02-0032 token 10 -- CD/NumForm=Digit/NumType=Card lemma '3,' does not match cardinal-number applied to form '3,', expected '3'
@nschneid
Copy link
Contributor

nschneid commented Dec 3, 2023

The third one is from an oddly spelled sentence:

I am expecting to pay something in the $3,to $5,000 range.

I guess the "000" got deleted (or was omitted to save space). Shouldn't the lemma be "3" as if it were "3 to 5 thousand"?

@rhdunn
Copy link
Contributor Author

rhdunn commented Dec 3, 2023

That works for me. I've only done a cursory analysis of these, so some of my assignments may be wrong.

@rhdunn
Copy link
Contributor Author

rhdunn commented Dec 3, 2023

In that case, it would also need a CorrectForm annotation.

@nschneid
Copy link
Contributor

nschneid commented Dec 3, 2023

Hmm, it would be nonstandard to write "$3 to $5,000 range" as well. I'll mark it as a typo of "$3,000".

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Dec 3, 2023 via email

nschneid added a commit that referenced this issue Dec 3, 2023
@nschneid
Copy link
Contributor

nschneid commented Dec 3, 2023

I don't think I've seen it before. Certainly the missing space is a typo.

@nschneid nschneid closed this as completed Dec 3, 2023
@AngledLuffa
Copy link
Contributor

AngledLuffa commented Dec 3, 2023 via email

@nschneid
Copy link
Contributor

nschneid commented Dec 3, 2023

Yes but not with a repeated dollar sign in text (that I know of)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants