Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use document-internal links in merged document #16

Closed
spyysalo opened this issue Jun 2, 2014 · 4 comments
Closed

use document-internal links in merged document #16

spyysalo opened this issue Jun 2, 2014 · 4 comments

Comments

@spyysalo
Copy link
Member

spyysalo commented Jun 2, 2014

The merged docs http://universaldependencies.github.io/docs/ud-dep-all.html and http://universaldependencies.github.io/docs/fi-dep-all.html contain the same relation tables as the corresponding index docs (since #12). However, the links to the relation documentation remain to the per-relation docs even in the merged doc. The merged document links should be document-internal instead.

@spyysalo spyysalo self-assigned this Jun 2, 2014
@spyysalo
Copy link
Member Author

spyysalo commented Sep 9, 2014

As of 9b71a3d, this should now be comparatively easy: replace the hard links in the docs with the generated [collection/type]() form and add a special case to the generator for merged pages.

@spyysalo
Copy link
Member Author

Working on the page http://universaldependencies.github.io/docs/fi/pos/all.html in ec17b1f. If no issues with the approach turn up, this should be repeated for all languages and collections.

spyysalo added a commit that referenced this issue Oct 31, 2014
spyysalo added a commit that referenced this issue Oct 31, 2014
spyysalo added a commit that referenced this issue Oct 31, 2014
@spyysalo
Copy link
Member Author

As of 1295c06, this now works for all Finnish "merged" pages (POS, feat, and dep). If no issues surface, the same pattern should be followed for others.

spyysalo added a commit that referenced this issue Oct 31, 2014
spyysalo added a commit that referenced this issue Oct 31, 2014
@spyysalo
Copy link
Member Author

Works for me now, suggest to open separate issues if something remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants