This repository has been archived by the owner on May 15, 2024. It is now read-only.
Serialize and deserialize Connecting #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustynaBroniszewska
force-pushed
the
redirect-connecting
branch
from
5a6de12
to
89668d3
Compare
JustynaBroniszewska
force-pushed
the
redirect-connecting
branch
2 times, most recently
from
3f76a3d
to
c22802b
Compare
JustynaBroniszewska
changed the title
JustynaBroniszewska
force-pushed
the
redirect-connecting
branch
2 times, most recently
from
bc34d91
to
2ddf440
Compare
| const {sdk, walletService} = useServices(); | ||
| const history = useHistory(); | ||
| const [name, setName] = useState<string | undefined>(undefined); | ||
| const [connectModal, setConnectModal] = useState<ConnectModal>('selector'); | ||
| const defaultModal = walletState.kind === 'Connecting' ? 'connectionFlow' : 'selector'; | ||
| const [connectModal, setConnectModal] = useState<ConnectModal>(defaultModal); |
There was a problem hiding this comment.
Why not make it a route?
xitronix
reviewed
Dec 6, 2019
Comment on lines
+26
to
+28
| walletService.initializeConnection(name).then(() => { | ||
| history.push('/connect/emoji'); | ||
| }); |
There was a problem hiding this comment.
It is not important, but i would like:
walletService.initializeConnection(name).then(() => history.push('/connect/emoji'));
JustynaBroniszewska
force-pushed
the
redirect-connecting
branch
from
d50b50a
to
e216823
Compare
marekkirejczyk
previously approved these changes
Dec 6, 2019
JustynaBroniszewska
force-pushed
the
redirect-connecting
branch
from
e216823
to
59c10a7
Compare
marekkirejczyk
previously approved these changes
Dec 6, 2019
xitronix
previously approved these changes
Dec 6, 2019
cehali
previously approved these changes
Dec 6, 2019
JustynaBroniszewska
dismissed stale reviews from cehali, xitronix, and marekkirejczyk
via
7e6d154
JustynaBroniszewska
force-pushed
the
redirect-connecting
branch
from
8c910d3
to
7e6d154
Compare
cehali
approved these changes
Dec 6, 2019
xitronix
approved these changes
Dec 6, 2019
marekkirejczyk
approved these changes
Dec 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.