Ensure resolution is divisible by 2 after scaling #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@future-figs thanks for this, yes please make it mod4 because some players can't play some mod2 resolutions. Panasonic TVs being one of them |
|
Thanks for explaining, changed to multiples of 4. |
|
Thanks! |
sf666
added a commit
to ik666/UniversalMediaServer
that referenced
this pull request
Mar 4, 2024
* v14_ums: (24 commits) fix HttpExchangeServletRequest Servlet implementation fix HttpExchangeServletRequest Servlet implementation fix ServerSentEvents implementation Ensure resolution is divisible by 2 after scaling (UniversalMediaServer#4507) Bump JRE from 17.0.9 to 17.0.10 (UniversalMediaServer#4509) log resource finding Bump @types/react from 18.2.55 to 18.2.59 in /react-client (UniversalMediaServer#4505) Bump @types/node from 18.19.17 to 18.19.18 in /react-client (UniversalMediaServer#4502) Bump eslint from 8.56.0 to 8.57.0 in /react-client (UniversalMediaServer#4503) Bump org.codehaus.mojo:exec-maven-plugin from 3.1.1 to 3.2.0 (UniversalMediaServer#4504) remove old paypal link remove old paypal link remove old paypal link log more on MediaScanner Bump MediaInfo to 24.01.1 and FFmpeg to 2024-02-22 (UniversalMediaServer#4500) loading overlay Bump the npm_and_yarn group across 1 directories with 1 update (UniversalMediaServer#4498) Removed broken PayPal link, replace with link to our donate page Fix Open Collective link Removed PayPal, added Open Collective Bump @testing-library/react from 14.1.2 to 14.2.1 in /react-client (UniversalMediaServer#4488) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue where some video files would not play with the renderer's max resolution set to 640x480. It turned out that the
scalefilter had calculated an output resolution with an odd number of pixels for the height, which caused libx264 to crash.This PR adds a black 1-pixel pad in either axis if needed, with the output centered. This makes the resolution divisible by 2 along both axes. It only applies to one usage of the
scalefilter because the others either get their output resolutions from the renderer's max resolution (instead of calculating some oddball res), or already have even-number padding implemented (usingconvertToModX). So, now all cases should be accounted for.One bit of inconsistency is that multiples of 2 are enforced, instead of multiples of 4 as in the existing code with
convertToModX. If multiples of 4 are required for some reason, then this should be edited to make it so.