v14.1

[SurfaceS]

Description of code changes

Implements latest Jetty (v12.0.8).
Implements latest JUPnP (v3.0.1).
Removed the JDK HTTP servlet server (personal implementation).
Stop using the deprecated tool 'Create React App' (no longer being maintained)
Implements Vite as replacement.

The webgui / webplayer are now served by Jetty (servlet).

Goal of the version

Remove multiple engine maintenance.
Remove Netty without stress. #4058

To test

We should focus on the webgui / webplayer tests first, as it is now served by Jetty servlets.
It will be easy to test as it is not changing settings / database or so that will break if we revert to v14 build.

Netty is kept as the default engine, letting us time to fix Jetty implementation (by changing the default engine in the GUI settings).
Once Jetty implementation is fully tested, we can remove all Netty related things (engine, deps, and so on).

Checklist

• Any relevant issues are referenced
• Any relevant Knowledge Base articles are written/modified
• Any relevant tests have been written/modified

[SurfaceS]

@SurfaceS ok cool, are you happy for it to be merged? I haven't found any problems with it

@SubJunk yes.

next step (v14.2) will be to use the jetty media server implementation as default, then we can remove completely netty.

[SurfaceS]

@SubJunk I made a cleanup in the changelog, then it will be easier to merge, after you build the 14.0.1 to fix 14.0.0 regressions.

I think we should build the 14.0.1 before releasing the 14.1.0, as you may not want to give the 14.0.0, that users will create issues (regression) already solved on 14.0.1.

[SubJunk]

@SurfaceS ok, I will release 14.0.1 today

[SubJunk]

I got this error on this branch, not sure whether it is related to it

08:34:07 INFO  Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException: Cannot invoke "java.awt.Window.pack()" because the return value of "javax.swing.SwingUtilities.getWindowAncestor(java.awt.Component)" is null
08:34:07 INFO  	at net.pms.swing.gui.tabs.status.RendererFrame.buildEditBar(RendererFrame.java:131)
08:34:07 INFO  	at net.pms.swing.gui.tabs.status.RendererFrame.buildPanel(RendererFrame.java:99)
08:34:07 INFO  	at net.pms.swing.gui.tabs.status.RendererFrame.update(RendererFrame.java:78)
08:34:07 INFO  	at net.pms.swing.gui.tabs.status.RendererPanel.lambda$updateRenderer$1(RendererPanel.java:200)
08:34:07 INFO  	at java.desktop/java.awt.event.InvocationEvent.dispatch(Unknown Source)
08:34:07 INFO  	at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
08:34:07 INFO  	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
08:34:07 INFO  	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
08:34:07 INFO  	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
08:34:07 INFO  	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
08:34:07 INFO  	at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
08:34:07 INFO  	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
08:34:07 INFO  	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
08:34:07 INFO  	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
08:34:07 INFO  	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
08:34:07 INFO  	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
08:34:07 INFO  	at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)

[SurfaceS]

I got this error on this branch, not sure whether it is related to it

08:34:07 INFO  Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException: Cannot invoke "java.awt.Window.pack()" because the return value of "javax.swing.SwingUtilities.getWindowAncestor(java.awt.Component)" is null
08:34:07 INFO  	at net.pms.swing.gui.tabs.status.RendererFrame.buildEditBar(RendererFrame.java:131)
08:34:07 INFO  	at net.pms.swing.gui.tabs.status.RendererFrame.buildPanel(RendererFrame.java:99)
08:34:07 INFO  	at net.pms.swing.gui.tabs.status.RendererFrame.update(RendererFrame.java:78)

It is not related to this branch, but it is fixed now

[SubJunk]

This is working really well for me. The performance improvement while browsing is very noticeable on my TV