Implementation of the latest stable Netty4 version

[valib]

@UniversalMediaServer/developers can we test the latest Netty 4 version if it is worth to be used? For me it works.

---

This change is

[SubJunk]

@valib cool, maybe we can release a beta version with this update to see how it works for people. Netty 4 always worked perfectly for me but others had issues, so I'm not able to test it reliably.

[Sami32]

@valib I was just thinking about that with the 5.2.1 version to see if freezing/timeouts will be here again...maybe not pertinent but hope doesn't kill anyone :-D
I will be happy to test it.

EDIT : i tested already and didn't get any streaming problems or errors in my LOG.
So maybe @skeptical with his chunk renderer can make more testing, because i guess you did already with Sony TV and PlayStation.

[SubJunk]

This is working well for me. Maybe we can release it as a 7.0.0 beta soon, what do you think?

[Sami32]

@valib @SubJunk Look promising :-)

I meeted a warning in the LOG though, but i will do more testing this week-end.

WARN 2016-06-18 02:46:19.203 [main] Failed to find a usable hardware address from the network interfaces; using random bytes: 22:e9:f9:4f:86:54:0c:8d
DEBUG 2016-06-18 02:46:19.203 [main] -Dio.netty.machineId: 22:e9:f9:4f:86:54:0c:8d (auto-detected)

UMS-debug_Netty4_Failed.txt

EDIT : Not sure it's pertinent, but just wondering if this could affect positively #899 and #920 ?

AsciiString is a new CharSequence implementation which contains only 1-byte characters. You will find this class useful when you deal with a US-ASCII or ISO-8859-1 string.
For instance, the HTTP codec and STOMP codec in Netty use AsciiString to represent the header names. Because AsciiString does not have any conversion cost when encoding it into a ByteBuf, it guarantees better performance than using String.

EDIT 2 : Before it was UTF8 encoding.

INFO 2016-06-18 13:45:25.500 [main] Encoding: Cp1252
...
DEBUG 2016-06-18 14:09:16.109 [cling-53] Error parsing xml: com.sun.org.apache.xerces.internal.impl.io.MalformedByteSequenceException: Invalid byte 2 of 3-byte UTF-8 sequence.

UMS-debug_Netty4.1.1.txt.zip.txt

P.S. My bad :/ i was running directly from depandencies JAR snapshot, so -Dfile.encoding=utf-8 parameters was missing i guess.

[valib]

Rebased + merged to the latest master.

[valib]

@SubJunk now it is ready for testing

[SubJunk]

@valib I'm interested in getting this merged. I have tested it and it seems good to me. I am thinking of maybe separating it from v10, because it might make it harder to identify bugs in the API code, so what do you think about it going out as 9.6.0?

[valib]

@SubJunk agree with you to release it in the 9.6.0

[SubJunk]

Just a couple of comments before merge @valib

[SubJunk]

@valib I can see some exceptions in the logs after this merge. I haven't noticed any actual bugs so it may not be important but here they are:

[main] direct buffer constructor: unavailable
java.lang.UnsupportedOperationException: Reflective setAccessible(true) disabled
	at io.netty.util.internal.ReflectionUtil.trySetAccessible(ReflectionUtil.java:31)
	at io.netty.util.internal.PlatformDependent0$4.run(PlatformDependent0.java:233)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at io.netty.util.internal.PlatformDependent0.<clinit>(PlatformDependent0.java:227)
	at io.netty.util.internal.PlatformDependent.isAndroid(PlatformDependent.java:289)
	at io.netty.util.internal.PlatformDependent.<clinit>(PlatformDependent.java:92)
	at io.netty.channel.nio.NioEventLoop.newTaskQueue0(NioEventLoop.java:279)
	at io.netty.channel.nio.NioEventLoop.newTaskQueue(NioEventLoop.java:150)
	at io.netty.channel.nio.NioEventLoop.<init>(NioEventLoop.java:138)
	at io.netty.channel.nio.NioEventLoopGroup.newChild(NioEventLoopGroup.java:146)
	at io.netty.channel.nio.NioEventLoopGroup.newChild(NioEventLoopGroup.java:37)
	at io.netty.util.concurrent.MultithreadEventExecutorGroup.<init>(MultithreadEventExecutorGroup.java:84)
	at io.netty.util.concurrent.MultithreadEventExecutorGroup.<init>(MultithreadEventExecutorGroup.java:58)
	at io.netty.channel.MultithreadEventLoopGroup.<init>(MultithreadEventLoopGroup.java:52)
	at io.netty.channel.nio.NioEventLoopGroup.<init>(NioEventLoopGroup.java:96)
	at io.netty.channel.nio.NioEventLoopGroup.<init>(NioEventLoopGroup.java:91)
	at io.netty.channel.nio.NioEventLoopGroup.<init>(NioEventLoopGroup.java:72)
	at io.netty.channel.nio.NioEventLoopGroup.<init>(NioEventLoopGroup.java:52)
	at net.pms.network.HTTPServer.start(HTTPServer.java:117)
	at net.pms.PMS.init(PMS.java:630)
	at net.pms.PMS.createInstance(PMS.java:917)
	at net.pms.PMS.main(PMS.java:1087)

and

[main] jdk.internal.misc.Unsafe.allocateUninitializedArray(int): unavailable
java.lang.IllegalAccessException: class io.netty.util.internal.PlatformDependent0$6 cannot access class jdk.internal.misc.Unsafe (in module java.base) because module java.base does not export jdk.internal.misc to unnamed module @409bf450
	at java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Unknown Source)
	at java.base/java.lang.reflect.AccessibleObject.checkAccess(Unknown Source)
	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
	at io.netty.util.internal.PlatformDependent0$6.run(PlatformDependent0.java:347)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at io.netty.util.internal.PlatformDependent0.<clinit>(PlatformDependent0.java:338)
	at io.netty.util.internal.PlatformDependent.isAndroid(PlatformDependent.java:289)
	at io.netty.util.internal.PlatformDependent.<clinit>(PlatformDependent.java:92)
	at io.netty.channel.nio.NioEventLoop.newTaskQueue0(NioEventLoop.java:279)
	at io.netty.channel.nio.NioEventLoop.newTaskQueue(NioEventLoop.java:150)
	at io.netty.channel.nio.NioEventLoop.<init>(NioEventLoop.java:138)
	at io.netty.channel.nio.NioEventLoopGroup.newChild(NioEventLoopGroup.java:146)
	at io.netty.channel.nio.NioEventLoopGroup.newChild(NioEventLoopGroup.java:37)
	at io.netty.util.concurrent.MultithreadEventExecutorGroup.<init>(MultithreadEventExecutorGroup.java:84)
	at io.netty.util.concurrent.MultithreadEventExecutorGroup.<init>(MultithreadEventExecutorGroup.java:58)
	at io.netty.channel.MultithreadEventLoopGroup.<init>(MultithreadEventLoopGroup.java:52)
	at io.netty.channel.nio.NioEventLoopGroup.<init>(NioEventLoopGroup.java:96)
	at io.netty.channel.nio.NioEventLoopGroup.<init>(NioEventLoopGroup.java:91)
	at io.netty.channel.nio.NioEventLoopGroup.<init>(NioEventLoopGroup.java:72)
	at io.netty.channel.nio.NioEventLoopGroup.<init>(NioEventLoopGroup.java:52)
	at net.pms.network.HTTPServer.start(HTTPServer.java:117)
	at net.pms.PMS.init(PMS.java:630)
	at net.pms.PMS.createInstance(PMS.java:917)
	at net.pms.PMS.main(PMS.java:1087)

[valib]

@SubJunk it seems like known problem in Netty started with Java 9. See netty/netty#7769

this is expected and just a debug statement...

[valib]

@SubJunk other solution for java 11 is here https://stackoverflow.com/questions/57885828/netty-cannot-access-class-jdk-internal-misc-unsafe which works also for Java 14

[SubJunk]

@valib ok I'm happy to leave it since it doesn't seem like something to worry about

[valib]

@SubJunk agree