Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'BEGIN_REPLACE' - used in tool_communication #101

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fix 'BEGIN_REPLACE' - used in tool_communication #101

merged 1 commit into from
Jun 13, 2022

Conversation

rxjia
Copy link
Contributor

@rxjia rxjia commented May 12, 2022

Fix the position of 'BEGIN_REPLACE' - used in tool_communication

@rxjia
Copy link
Contributor Author

rxjia commented May 19, 2022

The {{BEGIN_REPLACE}} before "# HEADER_BEGIN" will not be executed by "externalcontrol-1.0.5.urcap".
Therefore, the "tool_voltage" setting is invalid when use_tool_communication=true.

fmauch
fmauch approved these changes Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, thanks!

@fmauch fmauch merged commit f7ce9f7 into UniversalRobots:boost Jun 13, 2022
@fmauch
Copy link
Collaborator

fmauch commented Oct 4, 2022

@Mergifyio backport master

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2022

Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@fmauch
Copy link
Collaborator

fmauch commented Oct 4, 2022

@Mergifyio copy master

@mergify mergify bot mentioned this pull request Oct 4, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2022

copy master

✅ Pull request copies have been created

mergify bot pushed a commit that referenced this pull request Oct 4, 2022
@rxjia @mergify
Fix 'BEGIN_REPLACE' - used in tool_communication (#101)
6a6494b 
(cherry picked from commit f7ce9f7)
fmauch pushed a commit that referenced this pull request Oct 4, 2022
@mergify @rxjia
Fix 'BEGIN_REPLACE' - used in tool_communication (copy #101) (#120)
cd6f4a7 
Fix 'BEGIN_REPLACE' - used in tool_communication (#101)

(cherry picked from commit f7ce9f7)

Co-authored-by: rxjia <60809735+rxjia@users.noreply.github.com>
This was referenced Oct 26, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rxjia @fmauch