Clear the queue when consumer reads from it #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmauch
reviewed
Mar 24, 2022
There was a problem hiding this comment.
Thank you for your contribution! This looks good to me!
However, I'd like to extend the function's documentation a little. @corycrean would you agree with my suggestion?
Co-authored-by: Felix Exner <felix_mauch@web.de>
t-schnell
approved these changes
Apr 7, 2022
| } | ||
|
|
||
| // If the queue is empty, wait for a package. | ||
| return res || queue_.waitDequeTimed(product, timeout); |
There was a problem hiding this comment.
Personally not a fan of this type of return structure, but I can accept that as subjective.
|
Thanks again @corycrean |
urmahp
pushed a commit
to urmahp/Universal_Robots_Client_Library
that referenced
this pull request
Sep 5, 2022
Get the latest package each time the consumer reads from the queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
getLatestProductcallsqueue_.waitDequeTimedto retrieve a package from the queue, which means that it always retrieves the oldest package from the queue (when the queue contains more than one package). The additional packages remain in the queue, which can cause the queue to fill up over time and lead toPipeline producer overflowed!errors:Universal_Robots_Client_Library/include/ur_client_library/comm/pipeline.h
Lines 410 to 413 in 8f20b42
This PR modifies
getLatestProductso that it always returns the most recent package from the queue, and discards older ones.