Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for the control interface classes #112

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

urmahp
Copy link
Collaborator

@urmahp urmahp commented Aug 26, 2022

No description provided.

@fmauch
Copy link
Collaborator

fmauch commented Sep 24, 2022

Let's rebase this once #107 got merged.

@fmauch
Copy link
Collaborator

fmauch commented Sep 26, 2022

Rebased onto current master so all CI step should succeed.

Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Moving the setup into the fixtures is a debatable feature, so I'll approve this, but will only merge this after discussing that topic.

tests/test_reverse_interface.cpp Outdated Show resolved Hide resolved
tests/test_script_sender.cpp Outdated Show resolved Hide resolved
tests/test_script_sender.cpp Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Base: 41.13% // Head: 51.29% // Increases project coverage by +10.16% 🎉

Coverage data is based on head (5f4680b) compared to base (f31f998).
Patch coverage: 95.90% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #112       +/-   ##
===========================================
+ Coverage   41.13%   51.29%   +10.16%     
===========================================
  Files          76       82        +6     
  Lines        2064     2462      +398     
  Branches      256      279       +23     
===========================================
+ Hits          849     1263      +414     
+ Misses       1102     1069       -33     
- Partials      113      130       +17     
Impacted Files Coverage Δ
tests/test_script_sender.cpp 93.18% <93.18%> (ø)
tests/test_trajectory_point_interface.cpp 95.28% <95.28%> (ø)
tests/test_reverse_interface.cpp 97.18% <97.18%> (ø)
src/control/reverse_interface.cpp 86.53% <100.00%> (+86.53%) ⬆️
src/ur/ur_driver.cpp 0.00% <0.00%> (ø)
src/rtde/data_package.cpp 62.50% <0.00%> (ø)
include/ur_client_library/types.h 0.00% <0.00%> (ø)
include/ur_client_library/ur/ur_driver.h 0.00% <0.00%> (ø)
include/ur_client_library/comm/tcp_socket.h 0.00% <0.00%> (ø)
src/control/script_command_interface.cpp 0.00% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@urmahp
Copy link
Collaborator Author

urmahp commented Sep 26, 2022

Looks good to me. Moving the setup into the fixtures is a debatable feature, so I'll approve this, but will only merge this after discussing that topic.

I think it would be a good idea to make the setup part of the fixture, since it is identical for all the tests, so I will have a look at that.

This adds tests for
* script sender
* reverse interface
* trajectory point interface
@fmauch
Copy link
Collaborator

fmauch commented Sep 26, 2022

Squashed to re-trigger code-cov report.

@fmauch
Copy link
Collaborator

fmauch commented Sep 26, 2022

Just for clarity: This is currently being held back as @urmahp wanted to move code to the test fixture. Once this is done, this should be ready to merge.

@fmauch fmauch merged commit fc3875a into UniversalRobots:master Oct 4, 2022
@urmahp urmahp deleted the control_interface_test branch October 10, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants