-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for the control interface classes #112
Conversation
Let's rebase this once #107 got merged. |
d263a09
to
07f6850
Compare
Rebased onto current master so all CI step should succeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Moving the setup into the fixtures is a debatable feature, so I'll approve this, but will only merge this after discussing that topic.
Codecov ReportBase: 41.13% // Head: 51.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
===========================================
+ Coverage 41.13% 51.29% +10.16%
===========================================
Files 76 82 +6
Lines 2064 2462 +398
Branches 256 279 +23
===========================================
+ Hits 849 1263 +414
+ Misses 1102 1069 -33
- Partials 113 130 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I think it would be a good idea to make the setup part of the fixture, since it is identical for all the tests, so I will have a look at that. |
This adds tests for * script sender * reverse interface * trajectory point interface
c45f36f
to
424ad5a
Compare
Squashed to re-trigger code-cov report. |
Just for clarity: This is currently being held back as @urmahp wanted to move code to the test fixture. Once this is done, this should be ready to merge. |
No description provided.