Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header guard to datatypes.h #189

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add header guard to datatypes.h #189

merged 1 commit into from
Nov 30, 2023

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Nov 16, 2023

No description provided.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e25ffc) 72.05% compared to head (a13e3a3) 72.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   72.05%   72.09%   +0.03%     
==========================================
  Files          71       71              
  Lines        2652     2652              
  Branches      337      337              
==========================================
+ Hits         1911     1912       +1     
  Misses        554      554              
+ Partials      187      186       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urrsk urrsk self-requested a review November 28, 2023 13:59
Copy link
Collaborator

@RobertWilbrandt RobertWilbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change that prevents simple user errors. I just realized that we are not 100% consistent with pragma once vs. header guard in our header files, maybe something to keep in mind in the future.

@RobertWilbrandt RobertWilbrandt merged commit 914e68c into master Nov 30, 2023
29 checks passed
@RobertWilbrandt RobertWilbrandt deleted the add_header_guard branch November 30, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants