Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change load_yaml to xacro.load_yaml after former was deprecated #43

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Change load_yaml to xacro.load_yaml after former was deprecated #43

merged 1 commit into from
Nov 3, 2022

Conversation

aditya2592
Copy link
Contributor

@aditya2592 aditya2592 commented Nov 2, 2022 •
edited
Loading

Avoids following error and allows URDF to load. Without this change, UR URDF can no longer be loaded into ROS packages

warning: Using load_yaml() directly is deprecated. Use xacro.load_yaml() instead.
warning: Using load_yaml() directly is deprecated. Use xacro.load_yaml() instead.
warning: Using load_yaml() directly is deprecated. Use xacro.load_yaml() instead.
warning: Using load_yaml() directly is deprecated. Use xacro.load_yaml() instead.

@fmauch
Copy link
Collaborator

fmauch commented Nov 3, 2022 •
edited
Loading

In principle I do agree, although I wouldn't draw the picture as dramatically, since this is "only" a warning. I am a bit confused by the failing test, though.

Edit: This seems to be an issue with pre-2.0.8. Since 2.0.8 is already synced to humble and will be synced to rolling in the next release, I'll merge this nevertheless.

@fmauch fmauch mentioned this pull request Nov 3, 2022
Closed
@fmauch fmauch linked an issue Nov 3, 2022 that may be closed by this pull request
Loading yaml with correct function #42
Closed
fmauch
fmauch approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@fmauch fmauch merged commit 6a5b5e5 into UniversalRobots:ros2 Nov 3, 2022
@aditya2592
Copy link
Contributor Author

Yes. This is a warning but after the humble sync on 11/2, this was preventing us from loading URDF

@aditya2592 aditya2592 deleted the aditya/humble_fix branch November 3, 2022 14:40
@aditya2592 aditya2592 restored the aditya/humble_fix branch November 3, 2022 15:18
@fmauch fmauch mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading yaml with correct function
3 participants
@aditya2592 @fmauch @adityaa1413