Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI configration to supprot galactic and rolling #142

Merged
merged 22 commits into from Sep 9, 2021

Conversation

destogl
Copy link
Contributor

@destogl destogl commented Jul 10, 2021

Changes:

- Make binary build really a build based on released binaries only. This should help detect issues like #140 and #131

  • Add binary builds for galactic and rolling.
  • Base coverage, build on rolling.
  • Add source builds for all distros and correct the branch names there.
  • Removes dedicated ursim build because it is integrated into testing of all other builds.

@destogl destogl added enhancement New feature or request future-work labels Jul 10, 2021
@destogl destogl self-assigned this Jul 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #142 (5fe860f) into main (9acf43a) will increase coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 5fe860f differs from pull request most recent head e356e34. Consider uploading reports for the commit e356e34 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##            main    #142      +/-   ##
========================================
+ Coverage   3.53%   3.59%   +0.05%     
========================================
  Files         13      13              
  Lines        962     947      -15     
  Branches     152     152              
========================================
  Hits          34      34              
+ Misses       858     843      -15     
  Partials      70      70              
Flag Coverage Δ
unittests 3.59% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrollers/src/force_torque_sensor_broadcaster.cpp 0.00% <0.00%> (ø)
ur_controllers/src/gpio_controller.cpp 0.00% <0.00%> (ø)
...ontrollers/src/speed_scaling_state_broadcaster.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b63fe7...e356e34. Read the comment docs.

@destogl
Copy link
Contributor Author

destogl commented Aug 19, 2021

@livanov93 and @nbbrooks Now all checks are passing. We can build for foxy, galactic and rolling. I also added ccache in builds. Please review and merge if you are happy.

Copy link
Contributor

@livanov93 livanov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

Copy link
Contributor

@livanov93 livanov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#162 will continue after merging this

@livanov93 livanov93 merged commit 5dd56d9 into main Sep 9, 2021
@destogl destogl deleted the update-ci-for-distros branch October 19, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants