-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calibration extraction pacakge #186
Conversation
890167a
to
f123db2
Compare
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
========================================
- Coverage 3.59% 3.45% -0.14%
========================================
Files 13 13
Lines 947 983 +36
Branches 152 152
========================================
Hits 34 34
- Misses 843 879 +36
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First comments. More about structure than functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Please just comment on extending ur_control.launch.py
. Did you test this in the simulator? Should I?
@destogl It has been already tested with ursim, together with latest changes of boost dependency removal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now. Thanks!
bb92f39
to
84a19ed
Compare
PR introduces
ur_calibration
package for calibration extraction.Closes #28