Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration extraction pacakge #186

Merged
merged 23 commits into from
Oct 6, 2021
Merged

Calibration extraction pacakge #186

merged 23 commits into from
Oct 6, 2021

Conversation

livanov93
Copy link
Contributor

@livanov93 livanov93 commented Sep 27, 2021

PR introduces ur_calibration package for calibration extraction.

Closes #28

@livanov93 livanov93 self-assigned this Sep 27, 2021
@livanov93 livanov93 linked an issue Sep 27, 2021 that may be closed by this pull request
@livanov93 livanov93 added the enhancement New feature or request label Sep 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #186 (3620c81) into main (1b121b7) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #186      +/-   ##
========================================
- Coverage   3.59%   3.45%   -0.14%     
========================================
  Files         13      13              
  Lines        947     983      +36     
  Branches     152     152              
========================================
  Hits          34      34              
- Misses       843     879      +36     
  Partials      70      70              
Flag Coverage Δ
unittests 3.45% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ur_controllers/force_torque_sensor_broadcaster.hpp 0.00% <ø> (ø)
...controllers/scaled_joint_trajectory_controller.hpp 0.00% <0.00%> (ø)
...ontrollers/src/force_torque_sensor_broadcaster.cpp 0.00% <0.00%> (ø)
ur_controllers/src/gpio_controller.cpp 0.00% <0.00%> (ø)
...rollers/src/scaled_joint_trajectory_controller.cpp 0.00% <0.00%> (ø)
...ontrollers/src/speed_scaling_state_broadcaster.cpp 0.00% <0.00%> (ø)
...ver/include/ur_robot_driver/hardware_interface.hpp 0.00% <ø> (ø)
ur_robot_driver/src/hardware_interface.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f43f9f7...3620c81. Read the comment docs.

Copy link
Contributor

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First comments. More about structure than functionality.

ur_calibration/CMakeLists.txt Outdated Show resolved Hide resolved
ur_calibration/CMakeLists.txt Outdated Show resolved Hide resolved
ur_calibration/CMakeLists.txt Outdated Show resolved Hide resolved
ur_calibration/LICENSE Outdated Show resolved Hide resolved
ur_calibration/README.md Outdated Show resolved Hide resolved
ur_calibration/README.md Outdated Show resolved Hide resolved
ur_calibration/README.md Outdated Show resolved Hide resolved
ur_calibration/README.md Outdated Show resolved Hide resolved
ur_calibration/README.md Outdated Show resolved Hide resolved
ur_calibration/README.md Show resolved Hide resolved
Copy link
Contributor

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Please just comment on extending ur_control.launch.py. Did you test this in the simulator? Should I?

@livanov93
Copy link
Contributor Author

@destogl It has been already tested with ursim, together with latest changes of boost dependency removal.

@livanov93 livanov93 requested a review from destogl October 4, 2021 08:28
Copy link
Contributor

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. Thanks!

@livanov93 livanov93 merged commit afa859d into main Oct 6, 2021
@livanov93 livanov93 deleted the livanov/calibration_devel branch October 6, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract calibration data from robot controller
4 participants