Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resend program service and enable headless mode #198

Merged

Conversation

livanov93
Copy link
Contributor

PR info:

  • Add resend_robot_program service into the gpio controller
  • Add interfaces neccessary for service to work
  • Enable headless_mode option

@livanov93 livanov93 requested a review from destogl October 7, 2021 20:12
@codecov-commenter
Copy link

Codecov Report

Merging #198 (ca556ce) into main (1b121b7) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #198      +/-   ##
========================================
- Coverage   3.59%   3.36%   -0.23%     
========================================
  Files         13      13              
  Lines        947    1010      +63     
  Branches     152     152              
========================================
  Hits          34      34              
- Misses       843     906      +63     
  Partials      70      70              
Flag Coverage Δ
unittests 3.36% <0.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ur_controllers/force_torque_sensor_broadcaster.hpp 0.00% <ø> (ø)
...controllers/scaled_joint_trajectory_controller.hpp 0.00% <0.00%> (ø)
...ontrollers/src/force_torque_sensor_broadcaster.cpp 0.00% <0.00%> (ø)
ur_controllers/src/gpio_controller.cpp 0.00% <0.00%> (ø)
...rollers/src/scaled_joint_trajectory_controller.cpp 0.00% <0.00%> (ø)
...ontrollers/src/speed_scaling_state_broadcaster.cpp 0.00% <0.00%> (ø)
...ver/include/ur_robot_driver/hardware_interface.hpp 0.00% <ø> (ø)
ur_robot_driver/src/hardware_interface.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa859d...ca556ce. Read the comment docs.

Copy link
Contributor

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small issue found. Probably unintentionally formatted like that.

Comment on lines 267 to 269
"mode"] == "Tr"
"u"
"e";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intended?

Copy link
Contributor

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested functionality using ursim and this PR is working. The robot program is run automatically if robot is not "OFF"-ed. Otherwise: power_on --> release_breaks --> resend_program services have to called.

@livanov93 livanov93 force-pushed the livanov/add_resend_robot_program_srv branch from ca556ce to ec7eb35 Compare October 14, 2021 09:03
@livanov93 livanov93 merged commit 33c01ac into UniversalRobots:main Oct 14, 2021
andy-Chien pushed a commit to NanyangBot/Universal_Robots_ROS2_Driver that referenced this pull request Oct 5, 2022
)

* Add service to gpio controller.

* Add resend interfaces in the hardware.

* Add resend program interfaces into ros2_control xacro.

* Fix -Wunused warning.

* Parametrize headless mode.

* Fix cpp linters.

* Fix line length.

* Fix xacro parsing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants