Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update header extension to remove compile warning. #285

Merged
merged 2 commits into from May 3, 2022
Merged

Update header extension to remove compile warning. #285

merged 2 commits into from May 3, 2022

Conversation

destogl
Copy link
Contributor

@destogl destogl commented Feb 1, 2022

This change removes compile warning on Rolling:

In file included from /home/deniss/workspace/robosoft-ai/smacc_rolling/src/Universal_Robots_ROS2_Driver/ur_robot_driver/include/ur_robot_driver/hardware_interface.hpp:49,
                 from /home/deniss/workspace/robosoft-ai/smacc_rolling/src/Universal_Robots_ROS2_Driver/ur_robot_driver/src/hardware_interface.cpp:36:
/opt/ros/rolling/include/tf2_geometry_msgs/tf2_geometry_msgs.h:35:2: warning: #warning This header is obsolete, please include tf2_geometry_msgs/tf2_geometry_msgs.hpp instead [-Wcpp]
   35 | #warning This header is obsolete, please include tf2_geometry_msgs/tf2_geometry_msgs.hpp instead

fmauch
fmauch approved these changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@destogl
Copy link
Contributor Author

destogl commented Feb 2, 2022

Ok, before merging this, we have to branch-out for galactic.

@fmauch fmauch added the humble Relevant for humble and higher ROS versions label Feb 17, 2022
This was referenced Apr 19, 2022
Closed
Merged
Merged
@fmauch fmauch merged commit 7e28bd5 into main May 3, 2022
@fmauch fmauch deleted the destogl-patch-1 branch May 3, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

@livanov93 livanov93 livanov93 approved these changes

Assignees
No one assigned
Labels
humble Relevant for humble and higher ROS versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@destogl @fmauch @livanov93