Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mock_hardware and mock_sensor_commands instead of fake #739

Merged
merged 2 commits into from Jul 13, 2023

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Jul 11, 2023

This has been deprecated a while back and was never adapted. This PR goes alongside UniversalRobots/Universal_Robots_ROS2_Description#77

This has been deprecated a while back and was never adapted.
Copy link
Collaborator

@RobertWilbrandt RobertWilbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation and the ur_calibration README still mention fake_hardware. Those places should get adjusted along with the launch files.

@fmauch
Copy link
Collaborator Author

fmauch commented Jul 12, 2023

This should not necessarily get backported, as on humble this only a warning.

@RobertWilbrandt RobertWilbrandt merged commit 333d0bc into UniversalRobots:main Jul 13, 2023
11 checks passed
@fmauch fmauch mentioned this pull request Jul 21, 2023
@fmauch fmauch deleted the mock_hardware branch August 28, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants