robot_driver: use pass_all_args to reduce verbosity #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapper launch files essentially only provide defaults, and the common launch file requires all arguments, so we can just forward them.
gavanderhoorn
commented
Jun 16, 2020
I did not know, this was possible! That should simplify maintenance a lot. |
has been supported since Indigo, so .. Perhaps you're not paying attention ;) |
Yes, I've just seen that in the docs. I think, I never read the docs for the |
fmauch
approved these changes
Jun 16, 2020
fmauch
added a commit
to fmauch/Universal_Robots_ROS_Driver
that referenced
this pull request
Jul 7, 2020
…#197) The wrapper launch files essentially only provide defaults, and the common launch file requires all arguments, so we can just forward them.
fmauch
added a commit
to fmauch/Universal_Robots_ROS_Driver
that referenced
this pull request
Jul 7, 2020
…#197) The wrapper launch files essentially only provide defaults, and the common launch file requires all arguments, so we can just forward them.
fmauch
added a commit
to fmauch/Universal_Robots_ROS_Driver
that referenced
this pull request
Jul 7, 2020
…#197) The wrapper launch files essentially only provide defaults, and the common launch file requires all arguments, so we can just forward them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per subject.
Note: I haven't tested this (as in: started the driver), but I expect it to work as described.