Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDf download dialogue shows single link #463

Closed
BinaryRoads opened this issue May 31, 2017 · 3 comments
Closed

PDf download dialogue shows single link #463

BinaryRoads opened this issue May 31, 2017 · 3 comments

Comments

@BinaryRoads
Copy link

The PDF download dialogue isn't customisable such as the seadragon plugin with the rendering option in the manifest.

We use the PDF plugin for showing converted office documents in the UV and want an extra download option for the original file. However the pdf download link must also be available.

Is there any option for this to make this possible?
We are working for the National Archives The Hague and this is holding us back at the moment.

@edsilv
Copy link
Member

edsilv commented Aug 31, 2017

Apologies for the slow reply.

This is where the download menu for the PDF extension is set up: https://github.com/UniversalViewer/universalviewer/blob/master/src/extensions/uv-pdf-extension/DownloadDialogue.ts

To add renderings support you would need to copy the code in: https://github.com/UniversalViewer/universalviewer/blob/master/src/extensions/uv-seadragon-extension/DownloadDialogue.ts#L433

However, we should try to avoid duplicating code. I will ask for opinions on the UV community call today regarding if/how to add renderings support to non-image manifests.

@edsilv
Copy link
Member

edsilv commented Aug 31, 2017

We think moving the renderings options to BaseDownloadDialogue makes sense, although the seadragon extension's download panel uses radio buttons and the other extensions do not. We think before moving it we should make all download options a link (remove the radio buttons).

@LlGC-szw
Copy link

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

@edsilv edsilv closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants