Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

chore(deps): Change cache dependencies #8

Merged
merged 25 commits into from May 31, 2022

Conversation

Distractic
Copy link
Contributor

@Distractic Distractic commented May 29, 2022

Context

The current dependency to cache information is not maintained.
So we need to switch on a modern and stable dependency.

Problem

The current dependency brought some issues :

  • Security issue from non updated deps
  • No connection pool to interact with redis
  • Size of data stored (the key was the path of the class and all object is stored, however to optimize, we can (sometimes) store only some information)

TODO

  • Change dependencies
  • Update services
  • Tests

Storage

To store information, a prefixKey can be configurated for all type of data.

The ClientIdentity are stored using the cliId:<uuid> as key and the name as value (or vice-versa according to the configuration).

The ProfileId are stored using the profId:<name> as key and the id as value.

The ProfileSkin are stored using the skin:<uuid> as key and the entiere object as value.

@Distractic Distractic requested review from Quentixx and Zyksa May 29, 2022 21:32
@github-actions
Copy link

github-actions bot commented May 29, 2022

Unit Test Results

  52 files  +12    52 suites  +12   11s ⏱️ -29s
112 tests +29  112 ✔️ +29  0 💤 ±0  0 ±0 

Results for commit a153bc8. ± Comparison against base commit 839b81b.

♻️ This comment has been updated with latest results.

build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
@Distractic Distractic mentioned this pull request May 30, 2022
3 tasks
@Distractic Distractic marked this pull request as ready for review May 31, 2022 18:08
@Distractic Distractic merged commit 6cf954f into feat/client_identity May 31, 2022
@Distractic Distractic deleted the chore/change_redis_dep branch May 31, 2022 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants