Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major refactoring to most components #801

Merged
merged 20 commits into from Nov 6, 2019
Merged

Major refactoring to most components #801

merged 20 commits into from Nov 6, 2019

Conversation

hisahi
Copy link
Contributor

@hisahi hisahi commented Oct 30, 2019 •
edited

Short description

Also addresses issues #757, #740, #544

DoD

I have:

  • added actual code.
  • produced clean code that passes ESLint.
  • code that actually does what it should.
  • documented the code or added documentation to the wiki.
  • added or modified test(s).
  • test(s) that actually pass.

@hisahi hisahi added frontend Only frontend (use "full-stack" if work in both) cleanup refactoring Changes to code, not to functionality work-in-progress For PRs (only); means that not yet ready for review/merge labels Oct 30, 2019
@hisahi hisahi mentioned this pull request Nov 1, 2019
Closed
@hisahi hisahi added full-stack If changes are needed both in frontend & backend and removed frontend Only frontend (use "full-stack" if work in both) labels Nov 2, 2019
@hisahi hisahi changed the title WIP: Major refactoring to most components Major refactoring to most components Nov 6, 2019
@hisahi hisahi removed the work-in-progress For PRs (only); means that not yet ready for review/merge label Nov 6, 2019
yumoL
yumoL suggested changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@yumoL yumoL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReviewStudent page: The text and point which should be copied to the review field don't change when checklist items are selected.

@hisahi
Copy link
Contributor Author

hisahi commented Nov 6, 2019

ReviewStudent page: The text and point which should be copied to the review field don't change when checklist items are selected.

Fixed now, one of the merges had been done wrong

@hisahi hisahi requested a review from yumoL November 6, 2019 21:16
@hisahi
Copy link
Contributor Author

hisahi commented Nov 6, 2019

I will merge this for now, if something is broken we can check later

@hisahi hisahi merged commit cbf4aea into trunk Nov 6, 2019
@hisahi hisahi deleted the refactor/components-2 branch November 6, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yumoL yumoL yumoL approved these changes

Assignees
No one assigned
Labels
cleanup full-stack If changes are needed both in frontend & backend refactoring Changes to code, not to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hisahi @yumoL