Get involved page improvements

UniversityRadioYork · Oct 5, 2023 · 15403fa · 15403fa
1 parent f7375e9
commit 15403fa
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/controllers/getinvolved.go b/controllers/getinvolved.go
@@ -4,7 +4,6 @@ import (
 	"log"
 	"net/http"
 	"sort"
-	"strings"
 
 	"github.com/UniversityRadioYork/2016-site/models"
 	"github.com/UniversityRadioYork/2016-site/structs"
@@ -23,9 +22,16 @@ func (s CollegeSorter) Swap(i, j int) {
 	s[i], s[j] = s[j], s[i]
 }
 func (s CollegeSorter) Less(i, j int) bool {
-	if strings.Contains(s[i].CollegeName, "N/A") || strings.Contains(s[i].CollegeName, "Unknown") {
-		return true
+	for _, v := range []string{"Unknown", "N/A - non student"} {
+		if s[i].CollegeName == v {
+			return true
+		}
+
+		if s[j].CollegeName == v {
+			return false
+		}
 	}
+
 	return s[i].CollegeName < s[j].CollegeName
 }
 

diff --git a/views/getinvolved.tmpl b/views/getinvolved.tmpl
@@ -5,8 +5,8 @@
 <meta name="twitter:creator" content="@{{.PageContext.MainTwitter}}">
 <meta property="og:locale" content="en_GB">
 <meta property="og:type" content="website">
-<meta property="og:title" content="Want to help York make incredible award winning radio?">
-<meta property="og:description" content="Want to join one of the best, largest and most diverse societies university has to offer? Whether you to hear your voice played out on the airwaves, break the biggest news stories as they happen, play with the state-of-the-art studios and computer systems, or just plain have fun, then URY is the place for you.">
+<meta property="og:title" content="Want to help York make incredible award-winning radio?">
+<meta property="og:description" content="Want to join one of the best, largest and most diverse societies the university has to offer? Whether you to hear your voice played out on the airwaves, break the biggest news stories as they happen, play with the state-of-the-art studios and computer systems, or just generally have fun, URY is the place for you.">
 <meta property="og:image" content='{{.PageContext.FullURL}}{{url "/images/open_graph-get_involved.jpg"}}'>
 <meta property="og:url" content='{{.PageContext.FullURL}}{{url "/getinvolved"}}'>
 {{end}}
@@ -29,9 +29,9 @@
   <div class="container container-padded">
     <div class="row">
       <div class="col">
-        <h4>Want to help York make incredible <strong>award winning</strong> radio?</h4>
+        <h4>Want to help make incredible, <strong>award-winning</strong> radio?</h4>
         <h4>Want to join one of the best, largest and most diverse societies the university has to offer?</h4>
-        <p>Whether you want to hear your voice played out on the airwaves, break the biggest news stories as they happen, play with state-of-the-art studios and computer systems, or just plain have fun, then URY is the place for you.
+        <p>Whether you want to hear your voice played out on the airwaves, break the biggest news stories as they happen, play with state-of-the-art studios and computer systems, or just generally have fun, URY is the place for you.
         </p>
       </div>
     </div>