-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically update now and next. #145
Conversation
Closes #41 |
(untested)
Soon to be tied into the auto-updating
Turns out this isn't at all related to C&N anymore. whoops.
Also fix jump to current show when nothing's on air
There's still a couple of complexity issues (which seem entirely valid but I don't know what to do about them) and one "generic item sink" which I think is a non-issue. Otherwise, ready for review Was also considering adding a bar in the style I thought this button would be far more tied into the C&N updater this PR was for, but it turned out not to be at all. Sorry Matt :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codacy's complexity threshold can probably be raised - we use 10 at work
Otherwise fine - just check your coding style - lots of missing spaces before {
and after ,
From what I remember, this API key is (or at least should be) the different public one only capable of doing end user side stuff (ie loading current and next, maybe sending in messages depending on how that's implemented).
We do need to do a clear out of the API keys / permissions, and have a "production website key" instead. The one in the config should probably be revoked.
Regards,
Matthew Stratford,
Web developer, AV technician & all round techy guy.
https://mstratford.net
…On 21 Jun 2018, 20:29 +0100, Brooke Hatton , wrote:
@Brookke commented on this pull request.
In views/partials/base.tmpl:
> @@ -53,6 +53,7 @@
{{block "footer-block" .}}
{{template "footer" .}}
{{end}}
+<script>var MyRadioAPIKey = {{.PageContext.MyRadioAPIKey }};</script>
I believe this same notation is used elsewhere
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
With regards to the API key, I'm inclined to agree with @LordAro.
|
Added new API key to database with required permissions (required permissions being literally none)
…ersityRadioYork/2016-site into mstratford-updating-nowNext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works then looks good to me other than a few erroneous lines/missing lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, seems to work changing my computer clock around.
Note #184 changes some of the text layout for the now and next. |
…stratford-updating-nowNext
Right, OK. I've fixed all the Codacy issues (bar the Complexity, which was recommended to change to 10 in the settings). Plz merge ❤️ |
Improvements still to make: