Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Radioplayer button with an in-page player #356

Open
wants to merge 10 commits into
base: development
Choose a base branch
from
Open

Replace Radioplayer button with an in-page player #356

wants to merge 10 commits into from

Conversation

ashhhleyyy
Copy link
Member

The URY Player(tm)

@ashhhleyyy
Copy link
Member Author

ashhhleyyy commented May 24, 2024 •
edited
Loading

Things still to do:

  • Show current time from playback (including the 15s online delay)
  • Scrubbing support through the local buffer
  • Close button
  • Make send message form not refresh the page

Update: removed scrubbing support from this initial version

@ashhhleyyy
Copy link
Member Author

Just needs some fixup on the mobile CSS (or alternatively, just use radioplayer on mobile)

@ashhhleyyy
Copy link
Member Author

Here's what the final thing looks like:
image

And on mobile:
image

@ashhhleyyy ashhhleyyy marked this pull request as ready for review May 28, 2024 00:04
@alyxbb
Copy link
Contributor

alyxbb commented May 28, 2024

is the send message updates a duplicate of #292?

@alyxbb alyxbb linked an issue Jun 12, 2024 that may be closed by this pull request
Send message not clear message has sent #126
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send message not clear message has sent
2 participants
@ashhhleyyy @alyxbb