Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show team members on team page #358

Merged
merged 1 commit into from
May 24, 2024
Merged

show team members on team page #358

merged 1 commit into from
May 24, 2024

Conversation

JP5457
Copy link
Contributor

@JP5457 JP5457 commented May 24, 2024

Does what it says on the tin

ashhhleyyy
ashhhleyyy reviewed May 24, 2024
View reviewed changes
Copy link
Member

@ashhhleyyy ashhhleyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly an issue with the PR, but it feels odd that secretary is only a member on management
image

@ashhhleyyy
Copy link
Member

@alyxbb just fixed it on myradio

ashhhleyyy
ashhhleyyy approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@ashhhleyyy ashhhleyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the broken css (which was there before this PR), looks good!

@JP5457 JP5457 merged commit 8ffc937 into development May 24, 2024
2 checks passed
@ashhhleyyy ashhhleyyy deleted the jp/show-officers branch May 27, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashhhleyyy ashhhleyyy ashhhleyyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JP5457 @ashhhleyyy