Template blocks #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves all of the <html></html> out of header and footer into a new
base template, which is now the main template loaded on controllers.
Content can be added into the base template using {{block "content" .}}.
Header and footer are still here for now, but have been reduced to their
non-HTMLy content: footer is currently empty.
|
It might be nice to have a utility |
|
Maybe you should write one :)
|
…e into mw-template-blocks
alyxbb
pushed a commit
that referenced
this pull request
May 15, 2024
…flict-resolution I fucked the merge conflict resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PRQ rearranges the template system to use Go 1.6-style inheritable blocks:
base.tmplwhich is the main template for every page;base.tmplstill includesheader.tmplandfooter.tmpl, but these no longer contain the<html>etc. tags;contentblock instead of includingheaderandfooter;Obviously, the final website will use a richer inheritance hierarchy than this, but this at least means we're not assembling the
<html><body>and</body></html>tags around the page, which made me feel a bit twitchy.