Fix issue with trying to parse "Not Scheduled" as timestamp #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It feels as if there should be some sort of 'unscheduled' flag on the season that is set when this happens. I suppose one could just test for the zero value on |
|
So there is the |
|
As long as it's nicely documented, I'm happy for a '0' timestamp to mean unscheduled |
|
Agreed although see #24 |
|
Update from @ChrisTheBaron required |
|
@LordAro what do I need to update here? :P |
ChrisTheBaron
force-pushed
the
chris-fix-firsttime
branch
from
238777a
to
98d9e78
Compare
ChrisTheBaron
force-pushed
the
chris-fix-firsttime
branch
from
98d9e78
to
ade153f
Compare
MattWindsor91
pushed a commit
that referenced
this pull request
Dec 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.