Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetCurrentTimeslot(): handle there being no current timeslot #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

markspolakovs
Copy link
Member

I'd quite like to just return nil, but that'd involve changing the return type to *Timeslot which is a breaking change >:(

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 20.0% when pulling d9c66c6 on marks/gettimeslot-none into 2b440aa on master.

@Brookke
Copy link
Member

Brookke commented Dec 29, 2020

Should probably include a test.

How much is actually using this part of myradio-go, just 2016-site right? If so I expect you could do the breaking change wouldn't be too much work if you did want to go down that route?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants