This repository has been archived by the owner on Feb 20, 2021. It is now read-only.
do not throw errors, as mongodb client would auto-reconnect by default #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2017 21:06
…t. also remove the bit for handling PC resuming from sleep hardly any practical value with it
|
Need to recreate this PR as a merge into the upstream project |
halfninja
reviewed
Feb 8, 2017
| @@ -607,7 +600,7 @@ function processJobs(extraJob) { | |||
| self._nextScanAt = new Date(now.valueOf() + self._processEvery); | |||
| self._findAndLockNextJob(name, definitions[name], function(err, job) { | |||
| if (err) { | |||
| throw err; | |||
| console.log('error with mongodb connection', err); | |||
There was a problem hiding this comment.
Console.log probably isn't appropriate, and we don't know at this point that it's definitely a mongo error.. could have been passed any error
| var s = this._mdb.s || this._mdb.db.s; | ||
| if (s.topology.connections().length === 0) { |
There was a problem hiding this comment.
I think we had trouble with the scheduler restarting when we took this away. It seemed to work best when we just stopped throwing the error, though I don't know why
| @@ -420,33 +420,26 @@ Agenda.prototype._findAndLockNextJob = function(jobName, definition, cb) { | |||
| var self = this, | |||
| now = new Date(), | |||
| lockDeadline = new Date(Date.now().valueOf() - definition.lockLifetime); | |||
|
|
|||
| // Don't try and access Mongo Db if we've lost connection to it. Also see clibu_automation.js db.on.close code. NF 29/04/2015 | |||
| // Trying to resolve crash on Dev PC when it resumes from sleep. | |||
| var s = this._mdb.s || this._mdb.db.s; | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.