feat: add feature_enabled property to variants
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tymek
force-pushed
the
feat/new-variant-interface
branch
from
66a46bc
to
7a8cc91
Compare
This was referenced Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Added
feature_enabledproperty in Variant to indicate feature toggle status independent of variant presence.Related to Unleash/unleash-client-python#284
Internal ticket: issue/SR-151/update-client-spec-to-include-feature-enabled-property-in-variant
Use case:
Before this change, clients had to check if variants existed for a specific feature or use a combination of get_variant() and is_enabled() calls, which could lead to inaccurate metrics. This change allows for a single method call that provides complete information about the feature's enablement and associated variant.