fix: allow start client to be used for config (#162)

fix: allow start client to be used for config

README.md

@@ -298,7 +298,7 @@ Upgrading should be as easy as running yarn again with the new version, but we m
 
 ## Upgrade path from v3 -> v4
 
-`startClient` option has been simpilfied. Now it will also work if you don't pass custom client with it, and in SSR (when `typeof window === 'undefined'`) it defaults to `false`.
+`startClient` option has been simplified. Now it will also work if you don't pass custom client with it. It defaults to `true`.
 
 #### Note on v4.0.0:
 The major release is driven by Node14 end of life and represents no other changes.  From this version onwards we do not guarantee that this library will work server side with Node 14.

src/FlagProvider.test.tsx

@@ -271,3 +271,27 @@ test('should not start client if startClient is false', () => {
   expect(localMock).not.toHaveBeenCalled();
   expect(stopMock).not.toHaveBeenCalled();
 });
+
+test('should not start client if startClient is false when passing config', () => {
+  const localMock = vi.fn();
+  const stopMock = vi.fn();
+  UnleashClientSpy.mockReturnValue({
+    getVariant: getVariantMock,
+    updateContext: updateContextMock,
+    start: localMock,
+    stop: stopMock,
+    isEnabled: isEnabledMock,
+    on: onMock,
+    off: offMock,
+  });
+
+
+  render(
+    <FlagProvider config={givenConfig} startClient={false}>
+      <div>Hi</div>
+    </FlagProvider>
+  );
+
+  expect(localMock).not.toHaveBeenCalled();
+  expect(stopMock).not.toHaveBeenCalled();
+});

src/FlagProvider.tsx

@@ -78,8 +78,7 @@ const FlagProvider: React.FC<React.PropsWithChildren<IFlagProvider>> = ({
     client.current.on('error', errorCallback);
     client.current.on('recovered', clearErrorCallback);
 
-    const shouldStartClient = startClient || !unleashClient;
-    if (shouldStartClient) {
+    if (startClient) {
       // defensively stop the client first
       client.current.stop();
       // start the client