Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support project query parameter (#69) #75

Merged
merged 9 commits into from
Jun 16, 2021

Conversation

daveleek
Copy link
Collaborator

@daveleek daveleek commented Apr 28, 2021

Description

This PR aims to add the projectId query parameter feature to the unleash-client-dotnet.
It does this by adding a setting for ProjectId to UnleashSettings. This setting is carried over to UnleashApiClient and there gets added to the feature toggles uri.

Fixes # (issue)
#69

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

It was tested by adding unit tests specifically for this feature and by running the entire test suite.
Also tested by debugging the WebApplication project in this repo with the different projectids from the demo host.
One unittest fails, but that also fails on master without my changes.: ShouldBeEnabledWhenExpected

  • UnleashApiClient_Project_Tests.FetchToggles_ForProject
  • UnleashApiClient_Project_Tests.FetchToggles_WithoutProject

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daveleek daveleek changed the title [WIP] Feature/supporting project query (#69) [WIP] feat: support project query parameter (#69) May 1, 2021
@daveleek daveleek changed the title [WIP] feat: support project query parameter (#69) feat: support project query parameter (#69) May 1, 2021
Copy link

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Looks good to me

@ivarconr ivarconr added this to In progress in Unleash v4.0 May 14, 2021
@chriswk chriswk merged commit 4313a49 into master Jun 16, 2021
Unleash v4.0 automation moved this from In progress to Done Jun 16, 2021
@daveleek daveleek deleted the feature/supporting-project-query branch June 28, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants