Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: variants custom stickiness #77

Merged
merged 5 commits into from
Jul 2, 2021

Conversation

daveleek
Copy link
Collaborator

@daveleek daveleek commented May 9, 2021

Description

This is a Work In Progress
This PR intends to implement issue #72. Custom stickiness for variants.

Fixes # (issue)
#72

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • VariantUtilsTests.Custom_Stickiness_CustomField_528_Yields_Blue
  • VariantUtilsTests.Custom_Stickiness_CustomField_16_Yields_Blue
  • VariantUtilsTests.Custom_Stickiness_CustomField_198_Yields_Red
  • VariantUtilsTests.Custom_Stickiness_CustomField_43_Yields_Green
  • VariantUtilsTests.Custom_Stickiness_CustomField_112_Yields_Yellow

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daveleek daveleek changed the title [WIP] feat: variants custom stickiness feat: variants custom stickiness May 16, 2021
Copy link

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daveleek daveleek merged commit c01cee9 into master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants