force getVariant to also add to the feature toggle metrics counter #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonfournier
commented
Dec 15, 2022
Comment on lines
+238
to
+239
| m.add(name, enabled, 1) | ||
| m.metricsChannels.count <- metric{Name: name, Enabled: enabled} |
There was a problem hiding this comment.
I believe this is necessary but I'm not 100% sure - since we're now incrementing the counter for feature toggles, it makes sense to now add this to the channel
Same as #123 (comment)
gastonfournier
changed the base branch from
v3
to
force-variants-to-count-toggle-metric
gastonfournier
commented
Dec 20, 2022
gastonfournier
changed the base branch from
force-variants-to-count-toggle-metric
to
v3
added 2 commits
December 20, 2022 12:44
client.go
Outdated
| } | ||
|
|
||
| // GetVariantWithoutMetrics abstracts away the logic for resolving a variant without metrics | ||
| func (uc *Client) GetVariantWithoutMetrics(feature string, options ...VariantOption) *api.Variant { |
There was a problem hiding this comment.
I think this should be lowercase, we don't want to expose this through the public API (by default uppercase method names are public in go, and lowercase are private).
There was a problem hiding this comment.
Thanks! I didn't know that!
@nunogois learning opportunity here :) https://go.dev/doc/effective_go#names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces resolving a variant to correctly add to the feature toggle counter metrics. Also fixes an issue where variants wouldn't get counted for the default/disabled case (brings this SDK inline with the behaviour of its siblings)
Also, other unrelated changes:
unleashpackage and not having any test