Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultUnleash.isEnabled(toggleName, context) silently dropping context #181

Closed
hnicke opened this issue Dec 16, 2022 · 4 comments
Closed
Assignees

Comments

@hnicke
Copy link

hnicke commented Dec 16, 2022

Describe the bug

The Unleash Interface provides a function isEnabled(toggleName, context) with a default implementation.
In the default implementation, the context is silently dropped.
This is expected behavior i guess.

However, he DefaultUnleash implementation is missing an override for this function.
This leads to the behavior where DefaultUnleash.isEnabled(toggleName, context) silenlty drops the context.
Note that DefaultUnleash.isEnabled(toggleName, context, defaultValue) does not drop the context.

SDK information (language and version)

java client sdk 7.0.0

@hnicke hnicke added the bug label Dec 16, 2022
@hnicke hnicke changed the title DefaultUnleash does not override isEnabled(toggleName, context) DefaultUnleash.isEnabled(toggleName, context) silently dropping context Dec 16, 2022
@pransh15
Copy link

Hey @hnicke 👋
Thanks for submitting this, someone from the team will get back to you on this soon. 😄

@gastonfournier
Copy link
Contributor

Hi @hnicke the DefaultUnleash implementation seems to be working as expected (check #184 where I explained why is that). The interface is confusing nevertheless, so I'll bring this to @chriswk as an enhancement.

@gastonfournier gastonfournier self-assigned this Dec 26, 2022
@hnicke
Copy link
Author

hnicke commented Dec 26, 2022

Thank you for looking into this.
My bad - you are right!
For some odd reason it didn't work for me last week.
I can confirm it is working as intended.
Sorry for the inconvenience.

@hnicke hnicke closed this as completed Dec 26, 2022
@gastonfournier
Copy link
Contributor

No problem, still it is something that might be worth looking at!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants