Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This is just a test to validate #181
This validates that the context is not being dropped.
Looking into the details:
false
as defaultSetting:unleash-client-java/src/main/java/io/getunleash/Unleash.java
Lines 11 to 13 in 3e4b525
unleash-client-java/src/main/java/io/getunleash/Unleash.java
Lines 15 to 17 in 3e4b525
unleash-client-java/src/main/java/io/getunleash/DefaultUnleash.java
Lines 93 to 97 in 3e4b525
Discussion points
Unleash
interface (they should remember to implement that method). For being error-prone I consider we should not have a default implementation forUnleash
interface, but that's a breaking change and we should discuss itfallbackAction
and it might be better to have a method receiving all the parameters and this should be the only one you should implement:isEnabled(toggleName, context, fallbackAction, defaultSetting);
but I need to dig deeper on the meaning of those parameters and if it makes sense to have both.I'll talk about this with @chriswk who may have more context