Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fallback function #89

Closed
ivarconr opened this issue Nov 3, 2019 · 0 comments
Closed

feat: fallback function #89

ivarconr opened this issue Nov 3, 2019 · 0 comments

Comments

@ivarconr
Copy link
Member

ivarconr commented Nov 3, 2019

See Unleash/unleash-client-go#60 for details
dennis-menge pushed a commit to dennis-menge/unleash-client-java that referenced this issue Nov 12, 2019
relates to Unleash#89: to Added first implementation (draft) of fallb…
a4b2c44 
…ackAction
ivarconr pushed a commit that referenced this issue Feb 20, 2020
@dennis-menge @ivarconr
feat: Add support for fallback-action (#93)
1f18286 
* closes #89: to Added first implementation (draft) of fallbackAction

* Migrated to BiFunction for definition of fallback action, refactored methods according to feedback, added tests

* changed one test case to reflect correct implementation

* Added default implementation for isEnabled(String, BiFunction)

* Incorporated feedback, changed logical method layout in DefaultUnleash implementation, added default implementation in Unleash interface to avoid breaking existing implementation

* fix: fallbackAction and defaultSetting

Should not be possible to define both a fallback action and
a defaultSetting at the same time.

* fix: Improve fallbackAction unit-tests

Use mocked functions and verify that the fallBack action
is actually called with correct arguments.

* fix: remove final arguments in interface

* fix: simplify FakeUnleash for fallbackAction

* fix: formatting

* fix: counting at right place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ivarconr