Feature/api error handling #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage +4% 👍 |
|
Great work! +1 for merging! |
gardleopard
added a commit
that referenced
this pull request
Nov 24, 2014
Feature/api error handling
ivarconr
pushed a commit
that referenced
this pull request
Feb 20, 2020
ivarconr
pushed a commit
that referenced
this pull request
Feb 20, 2020
ivarconr
pushed a commit
that referenced
this pull request
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests for different errors that might come from the server.
I've focused on the server integration. Tests for invalid json and such will go into issue #12.
I will merge this pull request in some hours if no show stoppers are detected.