fix: force get variant is back #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
renovate bot
added a commit
to Unleash/unleash
that referenced
this pull request
Aug 1, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [unleash-client](https://togithub.com/Unleash/unleash-client-node) | [`4.1.0-beta.5` -> `4.1.0`](https://renovatebot.com/diffs/npm/unleash-client/4.1.0-beta.5/4.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Unleash/unleash-client-node (unleash-client)</summary> ### [`v4.1.0`](https://togithub.com/Unleash/unleash-client-node/releases/tag/v4.1.0) [Compare Source](https://togithub.com/Unleash/unleash-client-node/compare/v4.1.0-beta.5...v4.1.0) #### What's Changed - feat: strategy variants by [@​kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#482 - fix: remove unused segment fields by [@​kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#489 - feat: expose config type by [@​kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#491 - fix:fetch lib with its deps by [@​kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#492 - fix: force get variant is back by [@​kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#493 - refactor: strategy variants inside strategy by [@​kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#494 - feat: variant on enabled toggle metrics by [@​kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#495 - chore(deps): update dependency nock to v13.3.2 by [@​renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#488 - chore(deps): update dependency eslint to v8.45.0 by [@​renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#490 - chore(deps): update typescript-eslint monorepo to v5.62.0 by [@​renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#483 - chore(deps): update dependency eslint-config-airbnb-typescript to v17.1.0 by [@​renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#487 - chore(deps): update dependency eslint-plugin-prettier to v5 by [@​renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#485 - feat: version bump non beta by [@​kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#496 **Full Changelog**: Unleash/unleash-client-node@v4.0.2...v4.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNC4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
forceGetVariant should still be used in proxy/frontend API because it's not emitting impression events. The only difference is that it now evaluates the toggle under the hood (for the strategy variants support) because the experiments confirmed it's not skewing % distribution. I'm afraid that if we switch proxy and frontend SDK to getVariant the impression event will be emitted twice from the client SDK AND frontend API/proxy
Important files
Discussion points