feat: customHeaderFunction to dynamic setting headers #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarconr
reviewed
Nov 3, 2019
| @@ -126,7 +135,7 @@ export default class Metrics extends EventEmitter { | |||
| return true; | |||
| } | |||
|
|
|||
| sendMetrics(): boolean { | |||
| async sendMetrics(): Promise<boolean> { | |||
There was a problem hiding this comment.
Making this return a Promsie would that not require the calling method to await it to make sure it actually is executed?
(this.sendMetrics(); on line 79).
There was a problem hiding this comment.
nvm; this is not a requirement i javascript
ivarconr
reviewed
Nov 3, 2019
| @@ -93,19 +97,24 @@ export default class Metrics extends EventEmitter { | |||
| this.disabled = true; | |||
| } | |||
|
|
|||
| registerInstance(): boolean { | |||
| async registerInstance(): Promise<boolean> { | |||
There was a problem hiding this comment.
calls to this method should now be awaiting the response.
There was a problem hiding this comment.
nvm; this is not a requirement i javascript
ivarconr
approved these changes
Nov 3, 2019
ivarconr
changed the title
|
released as part of 3.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #151