Add support to provide namePrefix and tags for filtering #237
Conversation
test/url-utils.test.js
Outdated
|
|
||
| test('geturl should return url with two tags if two tags are provided', t => { | ||
| const result = getUrl('http://unleash-app.com', '', '', ['tagName:tagValue', 'tagName2:tagValue2']); | ||
| t.true(result === 'http://unleash-app.com/client/features?tag=tagName:tagValue&tag=tagName2:tagValue2'); |
There was a problem hiding this comment.
I think this will work out of the box with express. In other examples we have been using empty square bracket for array bases query params like this:
http://unleash-app.com/client/features?tag[]=tagName:tagValue&tag[]=tagName2:tagValue2
There was a problem hiding this comment.
What do you recommend to do with it?
There was a problem hiding this comment.
I tried reading up on the standards and it seems to be quite unclear both brackets and repeat format seems to be supported by express (unleash-server).
I do however think it will be worth while to urlEncode the tagName:tagValue params
src/url-utils.ts
Outdated
| } | ||
| if (tags) { | ||
| tags.forEach((tag) => { | ||
| params.append('tag', tag); |
There was a problem hiding this comment.
I think we should do a encodeURIComponent like this:
params.append('tag', encodeURIComponent(tag));
No description provided.