Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflows #460

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Update workflows #460

merged 2 commits into from
Jun 9, 2023

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Jun 7, 2023 •
edited

Unified release action

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Coverage Status

coverage: 91.617%. remained the same when pulling ccf96e1 on update-workflows into 764b71c on main.

@Tymek Tymek marked this pull request as ready for review June 7, 2023 14:49
gastonfournier
gastonfournier approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice! Is this generating also the changelog? I notice this also handles the version, so this could be a nice improvement for our release process in Unleash

@Tymek Tymek merged commit fc233db into main Jun 9, 2023
5 checks passed
@Tymek Tymek deleted the update-workflows branch June 9, 2023 08:37
@Tymek
Copy link
Member Author

Tymek commented Jun 9, 2023 •
edited

Is this generating also the changelog?

Yes. https://github.com/Unleash/.github/blob/main/.github/workflows/npm-release.yml#L74-L94
Simple version of changelog, in GitHub Releases. not in the code, not from conventional commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonfournier gastonfournier gastonfournier approved these changes

@kwasniew kwasniew Awaiting requested review from kwasniew

@sjaanus sjaanus Awaiting requested review from sjaanus

@sighphyre sighphyre Awaiting requested review from sighphyre

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tymek @gastonfournier