Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: match variant and feature types with Unleash OpenAPI #565

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix: match variant and feature types with Unleash OpenAPI #565

merged 1 commit into from
Jan 12, 2024

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Jan 11, 2024 •
edited

About the changes

  • Node SDK FeatureInterface was expecting fields not guaranteed to appear in the response from Unleash API.
  • Added missing number variant payload type

@github-actions GitHub Actions
Copy link

Coverage Status

coverage: 91.003% (-0.1%) from 91.104%
when pulling d051df2 on fix/variant-payload-type
into cb6b89a on main.

@Tymek Tymek requested a review from kwasniew January 12, 2024 09:18
@Tymek Tymek marked this pull request as ready for review January 12, 2024 09:19
@Tymek Tymek merged commit 23287ed into main Jan 12, 2024
5 checks passed
@Tymek Tymek deleted the fix/variant-payload-type branch January 12, 2024 10:41
@kwasniew kwasniew mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwasniew kwasniew kwasniew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tymek @kwasniew